Add contributing guidelines and update README#278
Conversation
|
@RCheesley thanks so much for the suggestion! I'll apply them soon and let you know when they're ready. 👍🏼 In the meantime, I'd like to explain why I do below details across our docs:
AdmonitionsApplying GitHub admonitions for notes, tip, or warnings as part of the list does:
Here are some screenshot of examples: 1. Admonition as part of unordered listAs you can see, the admonition is out of the flow.
2. Admonition as part of ordered listImage 1Just like the example in unordered list, the admonition is out of the flow.
Image 2After the admonition, all instructions are still belong to point 4. But the indentation follows the admonition instead of the point. This can cause confusions.
Image 3For this one, I indent the admonition just like we indent a paragraph that's part of a point. The indentation works great, but the admonition breaks.
The
|
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
… having a note in the middle of the list
This reverts commit 41c0ae0.
|
|
||
| If you're ready to push your changes to the remote repository and create a PR, please read the "[Push changes to the remote repository](#push-changes-to-the-remote-repository)" and "[Create a PR](#create-a-pr)" sections. | ||
|
|
||
| ### 3. Local development |
There was a problem hiding this comment.
I would probs put the working locally section first then have the codespaces as an 'if you can't work locally, use this' option.
Co-authored-by: Ruth Cheesley <ruth@ruthcheesley.co.uk>
|
@RCheesley TIL that we can wrap one point of order list with vale and it doesn't break it as in RST. 💡 Here's the preview for this PR: |
|
@RCheesley can you please add @adiati98 to docs at all contributors? TIA! ✨ |
|
@all-contributors please add @adiati98 for docs |
|
@adiati98 already contributed before to doc |




Description
This PR holds below changes:
.githubfolder.Linked issue
Closes #272
Closes #279
Screenshots or screen recordings